Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Aggregated Json Logs #1905

Merged
merged 1 commit into from May 15, 2024

Conversation

nathannaveen
Copy link
Contributor

Description of the PR

Included logs that state when the processing is complete, including the file name, document hash, the status, the files size, and the number of retries before the processing is complete.

What it looks like

No retries:

{"level":"info","ts":1715357735.7007687,"caller":"process/process.go:138","msg":"Processing complete{file_name 15 0 file:///testdata/syft-cyclonedx-docker.io-library-rabbitmq.latest.json <nil>} {document_hash 15 0 sha256:91089ed71548f8092f2a6e18451195537708341d60ff101322b550574119dcf4 <nil>} {status 15 0 success <nil>} {file_size 11 779 <nil>} {retries 11 0 <nil>}","guac-version":"v0.6.0-14-g9a274321-dirty","documentHash":"sha256:91089ed71548f8092f2a6e18451195537708341d60ff101322b550574119dcf4"}

After 3 retries:

{"level":"info","ts":1715357781.9435613,"caller":"process/process.go:138","msg":"Processing complete{file_name 15 0 deps.dev <nil>} {document_hash 15 0 sha256:3302ba0bd6a2b162366291cc187b2e70bdc2cafd58e90306bee4852afc61af54 <nil>} {status 15 0 success <nil>} {file_size 11 779 <nil>} {retries 11 3 <nil>}","guac-version":"v0.6.0-14-g9a274321-dirty","documentHash":"sha256:3302ba0bd6a2b162366291cc187b2e70bdc2cafd58e90306bee4852afc61af54"}

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
@pxp928 pxp928 added the needs-review Needs writer LGTM label May 15, 2024
@kodiakhq kodiakhq bot merged commit 761d672 into guacsec:main May 15, 2024
8 checks passed
arorasoham9 pushed a commit to arorasoham9/guac that referenced this pull request May 17, 2024
Signed-off-by: nathannaveen <42319948+nathannaveen@users.noreply.github.com>
Signed-off-by: Soham Arora <arorasoham9@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review Needs writer LGTM size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants