Bump node from 12 > 16 and bump incompatible packages (including webpack 2 > 3) #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhystmills
changed the title
|
Closed in favour of #343 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Node 12 has been out of maintenance for a while - this PR bumps it to v16. This is just about out of LTS itself but is an improvement on the current situation.
The PR also bumps Webpack to v3 in order to be compatible with the new node version. I still get some error output on installing dependencies but the app seems to run fine afterwards. I'll be following up with a PR bumping to Webpack v5, which solved the unhappy output (separate PR because v3 to v5 Webpack bump is generally quite complicated).
On bumping to Node 18+ - I'm getting build warnings that seem to be related to webpack v3. Once Webpack is on v5 we may be able to bump Node further.
How to test
Run this branch according to the instructions in the readme. Does it build and run locally?