Skip to content

Commit

Permalink
Merge pull request #570 from guardian/aa-lockfile
Browse files Browse the repository at this point in the history
chore: Add lockfile to `integration-test` project
  • Loading branch information
akash1810 committed May 19, 2021
2 parents 1f8c02d + 05b74f3 commit 476c0b2
Show file tree
Hide file tree
Showing 9 changed files with 22,797 additions and 20 deletions.
4 changes: 4 additions & 0 deletions integration-test/.eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
node_modules
cdk.out
.eslintrc.js
jest.config.js
20 changes: 20 additions & 0 deletions integration-test/.eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
module.exports = {
root: true,
env: {
node: true,
jest: true,
},
extends: ["@guardian/eslint-config-typescript"],
parserOptions: {
ecmaVersion: 2020,
tsconfigRootDir: __dirname,
sourceType: "module",
project: ["./tsconfig.eslint.json"],
},
plugins: ["@typescript-eslint"],
rules: {
"@typescript-eslint/no-inferrable-types": 0,
"import/no-namespace": 2,
},
ignorePatterns: ["**/*.js", "node_modules"],
};
5 changes: 0 additions & 5 deletions integration-test/.gitignore
Original file line number Diff line number Diff line change
@@ -1,7 +1,2 @@
# Output directory for generated cloudformation.
cdk.out

# Ignore package-lock.json to avoid the following error when reinstalling dependencies:
# npm ERR! notarget No matching version found for eslint-plugin-custom-rules@1.0.0.
# This is because we're installing @guardian/cdk from file, which is in turn installing eslint-plugin-custom-rules from file.
package-lock.json
3 changes: 3 additions & 0 deletions integration-test/.prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"printWidth": 120
}
11 changes: 0 additions & 11 deletions integration-test/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,14 +9,3 @@ The purpose of this is to ensure:
This is in reaction to [#356](https://github.com/guardian/cdk/pull/356) and [#365](https://github.com/guardian/cdk/pull/365) which broke the package.
The integration test helps increase confidence in any future changes to the library, _before_ publishing them.
That is, the feedback loop is shortened.

## A note about linting
As we're not using a lockfile, our dependency versions are non-deterministic.

This means we can install versions of eslint plugins with updated rules that cause the project to fail the lint check.

Rather than [firefight](https://github.com/guardian/cdk/pull/564) this, we're simply not linting this project as:
- This project is never consumed by anyone
- This project doesn't run anywhere
- This project doesn't get updated too often
- Understanding the original lockfile issues is a time sink

0 comments on commit 476c0b2

Please sign in to comment.