Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make the repo commitizen-friendly #335

Merged
merged 1 commit into from Mar 18, 2021
Merged

Conversation

stephengeller
Copy link
Contributor

What does this change?

According to these docs, we haven't made our repository commitizen-friendly. This PR merges in the result of running commitizen init cz-conventional-changelog --save-dev --save-exact on the repo and setting up basic config.

This will enable everyone to use the proper commitizen cli in the CDK repo with cz, git cz or npm cz.

Does this change require changes to existing projects or CDK CLI?

Nope.

How to test

In the root of the repo, run npx cz and see the interactive menu work!

How can we measure success?

We can use npx cz with ease!

@stephengeller stephengeller requested a review from a team March 18, 2021 13:08
@stephengeller stephengeller changed the title Make the repo commitizen-friendly chore: make the repo commitizen-friendly Mar 18, 2021
@stephengeller stephengeller merged commit fa6a0d3 into main Mar 18, 2021
@stephengeller stephengeller deleted the sg/commitizen branch March 18, 2021 13:26
@github-actions
Copy link
Contributor

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@akash1810
Copy link
Member

akash1810 commented Mar 19, 2021

Looks like we've moved to NPMv7 in this PR too as lockfileVersion in package-lock.json is now 2. Was this intentional? If so, shall we make a note of this in the README?

UPDATE: It looks like we're running NPMv6 in CI (see the build log on this PR) and I'm not sure if we're obeying the package-lock.json during the build as a result, so we'd also want to tell CI and CD to use NPMv7 too. It doesn't appear to be installed by default so we'd have to do something a bit horrible or stay on NPMv6 for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants