chore: Remove lockfile from integration-test project #647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akash1810
approved these changes
Jun 29, 2021
|
馃帀 This PR is included in version 21.0.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
We tried to introduce a lockfile for the integration tests relatively recently (see #570). Unfortunately, this seems to cause problems when attempting to upgrade dependencies.
More specifically, it seems that we end up referencing the wrong
@aws-cdkversions in thepackage-lock.json, despite bumping the version number in all of the appropriatepackage.jsonfiles. This means that we have to sort the lockfile out manually, which slows us down.Consequently, this PR removes the lockfile from the integration-test project entirely; I don't think it's hugely important to have deterministic builds for this test project anyway 馃