removed references to 'user-features' module booting commercial bu… #1130
+205
−951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dac5397 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dskamiotis
force-pushed
the
ds/remove-user-features-from-commercial
branch
from
eab8db3
to
a7ee269
Compare
domlander
reviewed
Nov 2, 2023
dskamiotis
force-pushed
the
ds/remove-user-features-from-commercial
branch
from
b60bd32
to
661c5d4
Compare
dskamiotis
force-pushed
the
ds/remove-user-features-from-commercial
branch
from
661c5d4
to
dc1d33f
Compare
dskamiotis
added
the
[beta] @guardian/commercial
dskamiotis
added
[beta] @guardian/commercial
|
🚀 0.0.0-beta-20231102170518 published to npm as a beta release |
|
This PR still needed @dskamiotis? |
I believe it is, but will need a few changes, i.e deleting user-features, and a rebase on main |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
This pull request removes all references to the 'user-features' module from the project. The 'user-features' module was previously used for managing user-related data and features but is no longer needed in this codebase.
Important Note
Some functions from 'user-features' are still required for specific features like
adblock-ask.tsandcommercial-features.ts, which rely on functions like shouldHideSupportMessaging() and isAdFreeUser(). To accommodate this, a partial user-features.ts file has been retained for these functions.This may not be a desirable long term solution but allows us to successfully test the user-features being set in one place (dotcom-rendering)
A discussion could be had regarding a centralised place for these functions eg. https://github.com/guardian/csnx/tree/main/libs/%40guardian
Why?
The 'user-features' module is no longer needed in this codebase as its functionality has been ported over to the
dotcom-renderingrepository. This change prevents redundant setting and retrieval of cookies, as user state management is now handled by 'dotcom-rendering'.This revised version maintains the essential information while being somewhat more concise and to the point. It still explains the purpose and the reason for the change.
Testing