Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add e2e tests for packages #110

Merged
merged 10 commits into from
Sep 21, 2022
Merged

add e2e tests for packages #110

merged 10 commits into from
Sep 21, 2022

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Sep 20, 2022 •
edited

What are you changing?

  • add e2e test for packages
  • renames hte files in the eslint configs to index.js to standardise package structures

Why?

#84 seemed like an innocent dep bump, but the subsequent releases in #92 were affected by sindresorhus/cpy#105 (or by me not understanding the changes to cpy@9).

this adds e2e tests that make sure what we bundle for publishing is usable

@sndrs sndrs requested a review from a team as a code owner September 20, 2022 09:35
@changeset-bot
Copy link

changeset-bot bot commented Sep 20, 2022 •
edited

⚠️ No Changeset found

Latest commit: 23a5ccf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

tjsilver
tjsilver approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@tjsilver tjsilver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A great addition! 💯

@sndrs sndrs merged commit 418dc4c into main Sep 21, 2022
@sndrs sndrs deleted the pkg-e2e-tests branch September 21, 2022 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjsilver tjsilver tjsilver approved these changes

Assignees
No one assigned
Labels
@guardian/browserslist-config @guardian/eslint-config @guardian/eslint-config-typescript @guardian/prettier @guardian/tsconfig 📦 npm Affects a @guardian package on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sndrs @tjsilver