Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update generated id with react useId #1447

Merged
merged 7 commits into from
May 24, 2024

Conversation

oliverabrahams
Copy link
Contributor

What are you changing?

  • swap generated id with react useId

Why?

Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: 71c2086

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label May 15, 2024
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label May 15, 2024
@oliverabrahams oliverabrahams added the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label May 15, 2024
Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

@oliverabrahams oliverabrahams removed 🐥 Canaries Triggers canary releases of any packages with changesets waiting. run_chromatic Runs chromatic when label is applied labels May 22, 2024
# Conflicts:
#	libs/@guardian/source/src/react-components/checkbox/Checkbox.tsx
#	libs/@guardian/source/src/react-components/checkbox/CheckboxGroup.tsx
#	libs/@guardian/source/src/react-components/choice-card/ChoiceCardGroup.tsx
#	libs/@guardian/source/src/react-components/radio/Radio.tsx
#	libs/@guardian/source/src/react-components/radio/RadioGroup.tsx
#	libs/@guardian/source/src/react-components/select/Select.tsx
#	libs/@guardian/source/src/react-components/text-area/TextArea.tsx
#	libs/@guardian/source/src/react-components/text-input/TextInput.tsx
@oliverabrahams oliverabrahams marked this pull request as ready for review May 23, 2024 15:03
@oliverabrahams oliverabrahams requested review from a team as code owners May 23, 2024 15:03
Copy link
Contributor

@SiAdcock SiAdcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💎 💎 💎

@oliverabrahams oliverabrahams added the run_chromatic Runs chromatic when label is applied label May 24, 2024
…th-react-use-id' into oa/replace-generate-source-id-with-react-use-id
@oliverabrahams oliverabrahams added the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label May 24, 2024
Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

@oliverabrahams oliverabrahams merged commit 522b68e into main May 24, 2024
22 checks passed
@oliverabrahams oliverabrahams deleted the oa/replace-generate-source-id-with-react-use-id branch May 24, 2024 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐥 Canaries Triggers canary releases of any packages with changesets waiting. 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants