Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create @guardian/source-development-kitchen #1459

Merged
merged 8 commits into from
May 22, 2024

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented May 16, 2024

What are you changing?

Creates @guardian/source-development-kitchen, in a correlate to #1435.

Why?

If foundations and react-components are becoming sections of @guardian/source, it makes sense to do the same for dev kitchen:

Before

import { palette } from '@guardian/source-foundations';
import { Button } from '@guardian/source-react-components';
import { StarRating } from '@guardian/source-react-components-development-kitchen';

After

import { palette } from '@guardian/source/foundations';
import { Button } from '@guardian/source/react-components';
import { StarRating } from '@guardian/source-development-kitchen/react-components';

This leaves us with two decoupled, consistent source packages:

  1. @guardian/source
  2. @guardian/source-development-kitchen

This means they are both then more extensible: they can stay as they are, or accommodate future developments, e.g.:

import { Button } from '@guardian/source/web-components';
import { psychadelicPalette } from '@guardian/source-development-kitchen/foundations';
import { StarRating } from '@guardian/source-development-kitchen/swift-components';

@sndrs sndrs requested review from a team as code owners May 16, 2024 15:33
Copy link

changeset-bot bot commented May 16, 2024

🦋 Changeset detected

Latest commit: 37a9051

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label May 16, 2024
Copy link
Contributor

Tip

Once this PR is ready to go, add the run_chromatic label to run the Chromatic tests.

This saves us a lot of money by not running the tests before we need them.

@sndrs sndrs added run_chromatic Runs chromatic when label is applied and removed 📦 npm Affects a @guardian package on NPM labels May 16, 2024
@github-actions github-actions bot added the 📦 npm Affects a @guardian package on NPM label May 16, 2024
@sndrs sndrs added the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label May 16, 2024
Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

@sndrs sndrs removed the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label May 16, 2024
@sndrs sndrs force-pushed the sndrs/source-development-kitchen branch from 279e13c to 8a07a61 Compare May 16, 2024 16:20
@sndrs
Copy link
Member Author

sndrs commented May 16, 2024

tested (with #1435) in guardian/dotcom-rendering#11399

pnpm-workspace.yaml Outdated Show resolved Hide resolved
@sndrs sndrs force-pushed the sndrs/source-development-kitchen branch from 05ddd12 to 760fd32 Compare May 21, 2024 15:00
@sndrs sndrs added the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label May 21, 2024
Copy link
Contributor

Note

The following canaries were published to NPM:

🐥

@sndrs sndrs removed the 🐥 Canaries Triggers canary releases of any packages with changesets waiting. label May 22, 2024
@sndrs sndrs enabled auto-merge (squash) May 22, 2024 10:39
@sndrs sndrs merged commit dfe0ebb into main May 22, 2024
20 checks passed
@sndrs sndrs deleted the sndrs/source-development-kitchen branch May 22, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants