Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move rollup configs to configs/rollup #1462

Merged
merged 2 commits into from
May 20, 2024
Merged

move rollup configs to configs/rollup #1462

merged 2 commits into from
May 20, 2024

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented May 17, 2024

What are you changing?

Moving rollup configs to configs/rollup

Why?

To align with #1461

@sndrs sndrs requested review from a team as code owners May 17, 2024 10:01
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 17, 2024 •
edited

⚠️ No Changeset found

Latest commit: 6135a8d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

oliverabrahams
oliverabrahams approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@oliverabrahams oliverabrahams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@sndrs sndrs changed the base branch from sndrs/storybook-configs to main May 17, 2024 15:36
@sndrs sndrs added the run_chromatic Runs chromatic when label is applied label May 17, 2024
@sndrs sndrs enabled auto-merge (squash) May 20, 2024 10:52
@sndrs sndrs merged commit ff58a2a into main May 20, 2024
20 checks passed
@sndrs sndrs deleted the sndrs/rollup-configs branch May 20, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxdvl mxdvl mxdvl left review comments

@oliverabrahams oliverabrahams oliverabrahams approved these changes

Assignees
No one assigned
Labels
@guardian/ab-core @guardian/ab-react @guardian/libs 📦 npm Affects a @guardian package on NPM run_chromatic Runs chromatic when label is applied
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sndrs @mxdvl @oliverabrahams