Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some issues with npm packages #98

Merged
merged 3 commits into from
Sep 15, 2022
Merged

fix some issues with npm packages #98

merged 3 commits into from
Sep 15, 2022

Conversation

sndrs
Copy link
Member

@sndrs sndrs commented Sep 15, 2022

What are you changing?

  • remove the exports field from package.json
    • we were using it incorrectly, and we need to work out what to do properly (cc @tjmw @mxdvl)
  • revert to cpy@8
  • add an e2e test for @guardian/libs to catch issues with bundling that we'd missed before now (catch things in this PR sooner)

Why?

  • resiliance

v9 seems to have a bug in it sindresorhus/cpy#105 (or i dont get something which i will have to make 9 work)
@sndrs sndrs requested a review from a team as a code owner September 15, 2022 15:34
@changeset-bot
Copy link

changeset-bot bot commented Sep 15, 2022

🦋 Changeset detected

Latest commit: fcc6ea2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@guardian/libs Patch
@csnx/npm-package Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added @guardian/libs 📦 npm Affects a @guardian package on NPM 🛠 workspace labels Sep 15, 2022
@sndrs sndrs merged commit 4fcc0cc into main Sep 15, 2022
@sndrs sndrs deleted the npm-package-fixes branch September 15, 2022 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@guardian/libs 📦 npm Affects a @guardian package on NPM 🛠 workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants