Skip to content

Commit

Permalink
Add hard coded test to layouts
Browse files Browse the repository at this point in the history
  • Loading branch information
abeddow91 committed May 21, 2024
1 parent b4ee16e commit 67bb137
Show file tree
Hide file tree
Showing 6 changed files with 24 additions and 7 deletions.
6 changes: 3 additions & 3 deletions dotcom-rendering/src/layouts/CommentLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -306,8 +306,7 @@ export const CommentLayout = (props: WebProps | AppsProps) => {
const inUpdatedHeaderABTest =
article.config.abTests.updatedHeaderDesignVariant === 'variant';

// const inStickyTitleTest =
// article.config.abTests.stickyTitleTest === 'variant';
const inTagLinkTest = false;

return (
<>
Expand Down Expand Up @@ -467,7 +466,7 @@ export const CommentLayout = (props: WebProps | AppsProps) => {

<main
data-layout="CommentLayout"
className="sticky-title-experiment"
className={inTagLinkTest ? 'sticky-title-experiment' : ''}
>
{isApps && (
<>
Expand Down Expand Up @@ -525,6 +524,7 @@ export const CommentLayout = (props: WebProps | AppsProps) => {
sectionLabel={article.sectionLabel}
sectionUrl={article.sectionUrl}
guardianBaseURL={article.guardianBaseURL}
inTagLinkTest={inTagLinkTest}
/>
</GridItem>
<GridItem area="border">
Expand Down
7 changes: 6 additions & 1 deletion dotcom-rendering/src/layouts/ImmersiveLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,7 @@ export const ImmersiveLayout = (props: WebProps | AppProps) => {
min-height: calc(50rem - ${navAndLabsHeaderHeight});
}
`;
const inTagLinkTest = false;

const LeftColCaption = () => (
<div
Expand Down Expand Up @@ -457,7 +458,10 @@ export const ImmersiveLayout = (props: WebProps | AppProps) => {
)}
</header>

<main data-layout="ImmersiveLayout">
<main
data-layout="ImmersiveLayout"
className={inTagLinkTest ? 'sticky-title-experiment' : ''}
>
{isApps && (
<>
<Island priority="critical">
Expand Down Expand Up @@ -517,6 +521,7 @@ export const ImmersiveLayout = (props: WebProps | AppProps) => {
guardianBaseURL={
article.guardianBaseURL
}
inTagLinkTest={inTagLinkTest}
/>
</div>
)}
Expand Down
7 changes: 6 additions & 1 deletion dotcom-rendering/src/layouts/LiveLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,7 @@ export const LiveLayout = (props: WebProps | AppsProps) => {

const inUpdatedHeaderABTest =
article.config.abTests.updatedHeaderDesignVariant === 'variant';
const inTagLinkTest = false;

return (
<>
Expand Down Expand Up @@ -459,7 +460,10 @@ export const LiveLayout = (props: WebProps | AppsProps) => {
)}
</div>
)}
<main data-layout="LiveLayout">
<main
data-layout="LiveLayout"
className={inTagLinkTest ? 'sticky-title-experiment' : ''}
>
{isApps && (
<>
<Island priority="critical">
Expand Down Expand Up @@ -533,6 +537,7 @@ export const LiveLayout = (props: WebProps | AppsProps) => {
sectionLabel={article.sectionLabel}
sectionUrl={article.sectionUrl}
guardianBaseURL={article.guardianBaseURL}
inTagLinkTest={inTagLinkTest}
/>
</GridItem>
<GridItem area="headline">
Expand Down
3 changes: 3 additions & 0 deletions dotcom-rendering/src/layouts/PictureLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,7 @@ export const PictureLayout = (props: WebProps | AppsProps) => {

const inUpdatedHeaderABTest =
article.config.abTests.updatedHeaderDesignVariant === 'variant';
const inTagLinkTest = false;

return (
<>
Expand Down Expand Up @@ -443,6 +444,7 @@ export const PictureLayout = (props: WebProps | AppsProps) => {
<main
data-layout="PictureLayout"
id="maincontent"
className={inTagLinkTest ? 'sticky-title-experiment' : ''}
lang={decideLanguage(article.lang)}
dir={decideLanguageDirection(article.isRightToLeftLang)}
>
Expand Down Expand Up @@ -473,6 +475,7 @@ export const PictureLayout = (props: WebProps | AppsProps) => {
sectionLabel={article.sectionLabel}
sectionUrl={article.sectionUrl}
guardianBaseURL={article.guardianBaseURL}
inTagLinkTest={inTagLinkTest}
/>
</GridItem>
<GridItem area="border">
Expand Down
4 changes: 3 additions & 1 deletion dotcom-rendering/src/layouts/ShowcaseLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,7 @@ export const ShowcaseLayout = (props: WebProps | AppsProps) => {
const renderAds = isWeb && canRenderAds(article);

const isLabs = format.theme === ArticleSpecial.Labs;
const inTagLinkTest = false;

return (
<>
Expand Down Expand Up @@ -522,7 +523,7 @@ export const ShowcaseLayout = (props: WebProps | AppsProps) => {
)}
<main
data-layout="ShowcaseLayout"
className="sticky-title-experiment"
className={inTagLinkTest ? 'sticky-title-experiment' : ''}
id="maincontent"
lang={decideLanguage(article.lang)}
dir={decideLanguageDirection(article.isRightToLeftLang)}
Expand Down Expand Up @@ -578,6 +579,7 @@ export const ShowcaseLayout = (props: WebProps | AppsProps) => {
sectionLabel={article.sectionLabel}
sectionUrl={article.sectionUrl}
guardianBaseURL={article.guardianBaseURL}
inTagLinkTest={inTagLinkTest}
/>
</GridItem>
<GridItem area="border">
Expand Down
4 changes: 3 additions & 1 deletion dotcom-rendering/src/layouts/StandardLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,7 @@ export const StandardLayout = (props: WebProps | AppProps) => {
const inUpdatedHeaderABTest =
article.config.abTests.updatedHeaderDesignVariant === 'variant';

const inTagLinkTest = false;
return (
<>
{isWeb && (
Expand Down Expand Up @@ -591,7 +592,7 @@ export const StandardLayout = (props: WebProps | AppProps) => {

<main
data-layout="StandardLayout"
className="sticky-title-experiment"
className={inTagLinkTest ? 'sticky-title-experiment' : ''}
>
{isApps && (
<>
Expand Down Expand Up @@ -682,6 +683,7 @@ export const StandardLayout = (props: WebProps | AppProps) => {
sectionUrl={article.sectionUrl}
guardianBaseURL={article.guardianBaseURL}
isMatch={!!footballMatchUrl}
inTagLinkTest={inTagLinkTest}
/>
</GridItem>
<GridItem area="border">
Expand Down

0 comments on commit 67bb137

Please sign in to comment.