Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump web-vitals to v1.1.2 #3198

Merged
merged 1 commit into from Jul 20, 2021
Merged

Bump web-vitals to v1.1.2 #3198

merged 1 commit into from Jul 20, 2021

Conversation

mxdvl
Copy link
Member

@mxdvl mxdvl commented Jul 20, 2021

What does this change?

Bumps to the latest v1 of web-vitals, v1.1.2.

v1.1.2 (2021-05-05)

  • Ignore negative TTFB values in Firefox (#147)
  • Add workaround for Safari FCP bug (#145)
  • Add more extensive FID feature detect (#143)

Why?

Ignores negative TTFB values. frontend is already on v1.1.2.

Further work

There is a new v2, which brings in breaking changes:

v2.1.0 (2021-07-01)

  • Add batch reporting support and guidance (#166

v2.0.1 (2021-06-02)

  • Detect getEntriesByName support before calling (#158

v2.0.0 (2021-06-01)

  • [BREAKING] Update CLS to max session window 5s cap 1s gap (#148)
  • Ensure CLS is only reported if page was visible (#149)
  • Only report CLS when FCP is reported (#154)
  • Update the unique ID version prefix (#157

Ignores negative TTFB values
@mxdvl mxdvl added the Dependencies Pull requests that update a dependency file label Jul 20, 2021
@mxdvl mxdvl requested review from nitro-marky and a team July 20, 2021 09:21
Copy link
Contributor

@nitro-marky nitro-marky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@github-actions
Copy link

Size Change: +163 B (0%)

Total Size: 929 kB

Filename Size Change
dist/coreVitals.js 3.47 kB +56 B (1%)
dist/coreVitals.legacy.js 6.16 kB +54 B (0%)
dist/ga.js 3.52 kB +24 B (0%)
dist/ga.legacy.js 3.77 kB +29 B (0%)
ℹ️ View Unchanged
Filename Size Change
dist/974.js 21.1 kB 0 B
dist/974.legacy.js 21.1 kB 0 B
dist/atomIframe.js 1.72 kB 0 B
dist/atomIframe.legacy.js 1.98 kB 0 B
dist/braze-web-sdk-core.js 36.1 kB 0 B
dist/braze-web-sdk-core.legacy.js 36.1 kB 0 B
dist/dynamicImport.js 2.82 kB 0 B
dist/dynamicImport.legacy.js 3.1 kB 0 B
dist/EditionDropdown.js 695 B 0 B
dist/EditionDropdown.legacy.js 704 B 0 B
dist/elements-CalloutBlockComponent.js 5.84 kB 0 B
dist/elements-CalloutBlockComponent.legacy.js 6.18 kB 0 B
dist/elements-DocumentBlockComponent.js 577 B 0 B
dist/elements-DocumentBlockComponent.legacy.js 607 B 0 B
dist/elements-EmbedBlockComponent.js 602 B 0 B
dist/elements-EmbedBlockComponent.legacy.js 596 B 0 B
dist/elements-InstagramBlockComponent.js 435 B 0 B
dist/elements-InstagramBlockComponent.legacy.js 453 B 0 B
dist/elements-InteractiveBlockComponent.js 2.54 kB 0 B
dist/elements-InteractiveBlockComponent.legacy.js 2.64 kB 0 B
dist/elements-InteractiveContentsBlockElement.js 1.89 kB 0 B
dist/elements-InteractiveContentsBlockElement.legacy.js 1.97 kB 0 B
dist/elements-MapEmbedBlockComponent.js 1.56 kB 0 B
dist/elements-MapEmbedBlockComponent.legacy.js 1.62 kB 0 B
dist/elements-RichLinkComponent.js 3.26 kB 0 B
dist/elements-RichLinkComponent.legacy.js 3.31 kB 0 B
dist/elements-SpotifyBlockComponent.js 1.49 kB 0 B
dist/elements-SpotifyBlockComponent.legacy.js 1.55 kB 0 B
dist/elements-UnsafeEmbedBlockComponent.js 431 B 0 B
dist/elements-UnsafeEmbedBlockComponent.legacy.js 449 B 0 B
dist/elements-VideoFacebookBlockComponent.js 1.57 kB 0 B
dist/elements-VideoFacebookBlockComponent.legacy.js 1.62 kB 0 B
dist/elements-VineBlockComponent.js 586 B 0 B
dist/elements-VineBlockComponent.legacy.js 604 B 0 B
dist/elements-YoutubeBlockComponent.js 2.11 kB 0 B
dist/elements-YoutubeBlockComponent.legacy.js 2.19 kB 0 B
dist/embedIframe.js 1.72 kB 0 B
dist/embedIframe.legacy.js 1.98 kB 0 B
dist/frontend.server.js 295 kB 0 B
dist/GetMatchStats.js 3.29 kB 0 B
dist/GetMatchStats.legacy.js 3.36 kB 0 B
dist/guardian-braze-components.js 15.2 kB 0 B
dist/guardian-braze-components.legacy.js 15.3 kB 0 B
dist/MostViewedFooterData.js 6.31 kB 0 B
dist/MostViewedFooterData.legacy.js 6.4 kB 0 B
dist/MostViewedRightWrapper.js 5.56 kB 0 B
dist/MostViewedRightWrapper.legacy.js 5.81 kB 0 B
dist/newsletterEmbedIframe.js 1.68 kB 0 B
dist/newsletterEmbedIframe.legacy.js 1.94 kB 0 B
dist/OnwardsLower.js 11.3 kB 0 B
dist/OnwardsLower.legacy.js 11.6 kB 0 B
dist/OnwardsUpper.js 11.9 kB 0 B
dist/OnwardsUpper.legacy.js 12.2 kB 0 B
dist/ophan.js 7.06 kB 0 B
dist/ophan.legacy.js 7.26 kB 0 B
dist/react.js 145 kB 0 B
dist/react.legacy.js 151 kB 0 B
dist/sentry.js 675 B 0 B
dist/sentry.legacy.js 686 B 0 B
dist/sentryLoader.js 3.09 kB 0 B
dist/sentryLoader.legacy.js 5.77 kB 0 B
dist/shimport.js 2.75 kB 0 B
dist/shimport.legacy.js 2.76 kB 0 B
dist/SignInGateMain.js 1.87 kB 0 B
dist/SignInGateMain.legacy.js 1.9 kB 0 B

compressed-size-action

@mxdvl mxdvl merged commit cde5468 into main Jul 20, 2021
@mxdvl mxdvl deleted the mxdvl/web-vitals-v1.1.2 branch July 20, 2021 10:03
@mxdvl
Copy link
Member Author

mxdvl commented Jul 20, 2021

This should be superseded by #3074

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants