Update DCR to TS 5.1 along will relevant packages #8094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -219 kB (-26%) 🎉 Total Size: 625 kB
ℹ️ View Unchanged
|
joecowton1
changed the title
…pdate-guardian-packages
…pdate-guardian-packages
joecowton1
changed the title
mxdvl
approved these changes
Jul 5, 2023
JamieB-gu
reviewed
Jul 5, 2023
| "tslib": "2.5.0", | ||
| "typescript-json-schema": "0.54.0", | ||
| "tslib": "2.5.3", | ||
| "type-fest": "3.12.0", |
There was a problem hiding this comment.
Would you be able to point me to where this is used? I can't find any references to it 🤔
There was a problem hiding this comment.
@guardian/commercial lists it as a dev dep but not a peer dep - @arelra might be something to look at?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Upgrades DCR to TS 5.1 all bumps all corresponding deps in line with peer dependencies.
Due to a number of issues with some Guardian packages being hoisted to the root dir while others stay in the project folders I've disabled hoisting for all @guardian packages.
In turn this has highlighted a number of issues with missing project dependencies which have needed resolving.
In short, the key changes are as follows:
node-fetchandmockdatedep to ar