Yarn upgrade archiver and logging #1379
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimhunty
reviewed
Jul 21, 2020
| @@ -13,7 +13,7 @@ export const frontController = (req: Request, res: Response) => { | |||
| req.params.version, | |||
| isPreview, | |||
| ) | |||
| const edition = req.params.edition | |||
| const edition = getEditionOrFallback(req.params.edition) | |||
There was a problem hiding this comment.
If this is just a yarn upgrade then why do we have changes to logic?
There was a problem hiding this comment.
I was wondering that! Basically after I ran yarn upgrade the validate step started failing - perhaps because of babel changes? Doesn't really make sense though.
There was a problem hiding this comment.
You can see the failure stuff here - basically it was angry about treating strings as typed values
jimhunty
approved these changes
Jul 23, 2020
philmcmahon
force-pushed
the
pm-more-lodash
branch
2 times, most recently
from
3310615
to
1aa14d5
Compare
philmcmahon
force-pushed
the
pm-more-lodash
branch
from
1aa14d5
to
bf5ed19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another effort to resolve the lodash vulnerability addressed in #1376 - I've run
yarn upgradeon archiver and logging