Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Alternative Ophan Implementation #2379

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jimhunty
Copy link
Contributor

Why are you doing this?

Previously we had a native implementation for Ophan. This was built using the native libraries with a Multiplatform Kotlin wrapper. However, this had performance issues and become unmaintained.

We have since attempted to use the Ophan npm library, however, this requires the document object which is not available in React Native as its not a web browser bases solution

As a result, we have dissected the endpoints used on theGuardian.com and made an attempt to replicate from inspecting the network console.

Changes

  • Ophan service is from the previous removal (chore: Remove Ophan #2206) but tweaked to work with the endpoint
  • Added packages to polyfill the missing crypto library so we can provide a unique identified for viewId
  • Ophan returns to being a required service and therefore we require users to accept the privacy settings again

@jimhunty jimhunty force-pushed the feat/alternative-ophan-implementation branch from 187bc32 to 51696c8 Compare February 21, 2024 09:03
@jimhunty jimhunty force-pushed the feat/alternative-ophan-implementation branch from 6345cec to cf30bbb Compare March 11, 2024 08:09
@jimhunty jimhunty marked this pull request as ready for review March 11, 2024 08:14
@jimhunty jimhunty requested a review from a team as a code owner March 11, 2024 08:14
Copy link
Contributor

@groakland groakland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimhunty jimhunty force-pushed the feat/alternative-ophan-implementation branch from 2d620f5 to d422b73 Compare March 13, 2024 07:58
@jimhunty jimhunty force-pushed the feat/alternative-ophan-implementation branch from c39cac6 to 2ed2119 Compare March 14, 2024 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants