Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert tag changes #2431

Closed
wants to merge 2 commits into from
Closed

Revert tag changes #2431

wants to merge 2 commits into from

Conversation

jonathonherbert
Copy link
Contributor

Why are you doing this?

A just-in-case PR, reverting #2429 and #2430 introduce problems over the weekend for Editions. Do not merge unless problems arise.

@jonathonherbert jonathonherbert added the ⛔️ Do not merge More work needed or proof of concept label May 10, 2024
@jonathonherbert jonathonherbert requested a review from a team as a code owner May 10, 2024 13:17
Copy link
Contributor

@groakland groakland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathonherbert
Copy link
Contributor Author

We've had a weekend of running #2429 and #2430 without complaint, so I'm happy this is no longer needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⛔️ Do not merge More work needed or proof of concept
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants