don't use apply method in gift code generator #2643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seen on PROD (merged by @johnduffell 13 minutes and 9 seconds ago)
Sentry Release: support-client-side, support |
|
✅ Testing in PROD passed! Details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are you doing this?
Following a discussion on RR dev channel, we agreed that the apply method behaviour is non-obvious, especially for client side engineers.
This PR removes the places we use it for normal code.
We also use it for case class smart constructors.
We probably prefer "parse" but you need more tricks (until we update to 2.13 - scala/scala#7702 ) to get rid of the built in
applyand not defeat the point of the constructor. Some options:or
or
or
keep it as apply.