Use Java 11 #401
Merged
Use Java 11 #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtyley
approved these changes
Aug 8, 2023
Co-authored-by: Roberto Tyley <roberto.tyley@gmail.com>
jonathonherbert
force-pushed
the
jsh/java-11
branch
from
5f19667
to
3c5acc8
Compare
|
Tested across the two services in CODE, LGTM. |
|
Thanks! I can confirm that the Public Repos Scala Steward job is now passing 🚀
|
|
Thanks for following up, @rtyley 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Use Java 11, not 8, to let us run this project with Scala Steward (it's currently failing.)
How to test
Deploy to CODE. All work as expected? Be sure to test both the management and checker services, perhaps by adding a new rule, publishing it, and testing it in Composer.