-
Notifications
You must be signed in to change notification settings - Fork 672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ListView: add support for multi-line items #1543
base: develop
Are you sure you want to change the base?
ListView: add support for multi-line items #1543
Conversation
Observation: perhaps we could make it so that ListWrapper has support for rendering multi-line text, so that folks do not need to implement a custom renderer for simple scenarios. The RenderUstr could look for '\n' and use that to wrap around the text. |
In the demo picture above, after selecting C: and hitting the up arrow, the contents of the lists changes and only 1 ListView item is visible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great.
All new features require two things missing from this PR though:
- Unit tests
- Sample code in a Scenario in UI Catalog. We are trying to deprecate demo.cs as it unstructured and doesn't scale as a way to discover samples.
Thanks.
@migueldeicaza now that you have tons of time on your hands 😉, wanna look at the changes requested here so we can merge this? |
I can't merge this until the requested changes are made... |
@migueldeicaza - what's the chance you'll be able to address this anytime soon? Would you prefer one of the other maintainers take it on? I'd like to get this merged! |
Happy to let someone look at it. I need to setup a .net development system again :-) |
I understand. I'll see if I can dive into this today. |
Dug in a little and this PR is far from ready:
I'm going to mark this PR as draft. Hopefully myself or someone will find the time to address it. |
Better version that supports multi-line ListView items.
In this example, a custom renderer draws two-line items, and requires ListView.ItemHeight to be set to 2: