Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3475. FakeConsole throws System.IndexOutOfRangeException using SetupFakeDriverAttribute. #3476

Merged
merged 1 commit into from
May 30, 2024

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented May 13, 2024

Fixes

Proposed Changes/Todos

  • Override Cols and Rows to resize the FakeConsole BufferWidth/BufferHeight

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner May 13, 2024 13:44
@tig tig merged commit 7451e79 into gui-cs:v2_develop May 30, 2024
1 check passed
@BDisp BDisp deleted the v2_3475_fakedriver-cols-rows-fix branch May 30, 2024 12:04
@dodexahedron
Copy link
Collaborator

We need to move that out of the core library anyway.

But that's a relatively low-importance issue with potentially relatively high effort to refactor, so I'm kinda ambivalent as to whether that should be done before or after V2 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants