Fixes #3469, #3473, #3482 - Dim.Auto fixes and Pos/Dim refactor to support TGD

[tig]

Fixes

• Fixes Dim.Auto (DimAutoStyle.Text) confuses TextFormatter when Width is absoulte and Height is auto #3469
• Fixes Dim.Auto screws up Pos.AnchorEnd() #3473
• Fixes v2 Pos classes need to support interrogation for TGD #3482
• Makes progress on Fixes #2432. Implements Dim.Auto for Content including subviews. #3451

Proposed Changes/Todos

• Replicate Dim.Auto screws up Pos.AnchorEnd() #3473 with unit tests.

The problem was I had removed some code I thought was dead in LayoutSubViews that forced a double calc of pos/dim in order to make DimAuto work when subviews depended on the view's dims. That code was very much "prototype" and didnt belong there anyway. I now have a much more elegant soution baked into SetRelativeLayout where if the Dim is DimAuto, we calcuate the Dim first (with Pos == 0) and then the Pos (using the resulalant dim).

This all highlighted clumisness in having ContentSize be nullable. So I changed it to non-nullable and added a SetContentsSize() method. The API is still a bit awkward to use so I may refactor it again at some point.

• Refactor AutoSizeTrue/False unit tests into new tests that make sense.

• New issue: Dim.Auto min: defines min size of the Frame. This should be min size of Content.Size!

I'm pretty confident #3473 is now fixed here.

Instead of focusing on #3469 (which is partially fixed), I'm now going to use this PR to also address:

• v2 Pos classes need to support interrogation for TGD #3482 in order to simplify @tznind's work on TGD.

• Remove nested class heirarchy in PosDim.

• Make the Pos/Dim types public - with API documentation that warns of pitfals of using them in normal situations... should not be needed!

• Make settings on the Pos/Dim types be publicly available (read only).

• Verify Dim.Auto (DimAutoStyle.Text) confuses TextFormatter when Width is absoulte and Height is auto #3469 is fixed.

Pull Request checklist:

• I've named my PR in the form of "Fixes #issue. Terse description."
• My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
• My code follows the Terminal.Gui library design guidelines
• I ran dotnet test before commit
• I have made corresponding changes to the API documentation (using /// style comments)
• My changes generate no new warnings
• I have checked my code and corrected any poor grammar or misspellings
• I conducted basic QA to assure all features are working

[tig]

And I keep wanting to suggest not spending too much time perfecting the xmldoc comments right now, in favor of holding that off til this stabilizes, to save work and make it less enticing to stick to something for sunk cost fallacy reasons, which we all are guilty of sometimes - especially when we get "GetItDoneItis." 😅

I don't think one can spend enough time on XML docs. Nothing drives clarity of thought more than writing clear, crisp, and complete English sentences.

So that's me both suggesting that but also not, if you'd rather do it now. 🤷‍♂️

We can turn that inspection up to error before release, too, to make sure we don't miss any, which is better than having them but them getting out of date as implementation drifts from what's written in them.

[tig]

@dodexahedron I believe I've addressed all your feedback with the exception of those where I've left the comment unresolved with a question I added.

Really good stuff, and I appreciate your diligence.

[dodexahedron]

And I keep wanting to suggest not spending too much time perfecting the xmldoc comments right now, in favor of holding that off til this stabilizes, to save work and make it less enticing to stick to something for sunk cost fallacy reasons, which we all are guilty of sometimes - especially when we get "GetItDoneItis." 😅

I don't think one can spend enough time on XML docs. Nothing drives clarity of thought more than writing clear, crisp, and complete English sentences.

So that's me both suggesting that but also not, if you'd rather do it now. 🤷‍♂️
We can turn that inspection up to error before release, too, to make sure we don't miss any, which is better than having them but them getting out of date as implementation drifts from what's written in them.

Man I swear I had responded to this, but I must have mis-clicked. I wrote it on another PC, though, so I'll look when I'm able to on that.

The gist was "Agreed - XmlDoc is good and not optional in the finished product, but changes are likely to result in lost/wasted effort."

If you don't mind, no biggie. Just trying to save you some work and time. :)

[dodexahedron]

Specifically for this PR, I mean. Not as a SOP.

[dodexahedron]

@dodexahedron I believe I've addressed all your feedback with the exception of those where I've left the comment unresolved with a question I added.

Really good stuff, and I appreciate your diligence.

Now that I've (I think) acked existing comments, I'm diving back in to pull and look at the current code. :)

My intent for this pass is, unless there are any biggies that should block the refactor til being fixed, to comment on small things but otherwise target a green light for this PR so we can work on things that are actual changes outside just the refactor (several of which we already let sneak in, but oh well).

[dodexahedron]

After I cram dinner down my neck, that is. 😆

[dodexahedron]

Not done yet. I fell asleep at some point, which was much needed (what a week, man).

And it's 3AM, so I'm headed back to bed. Should have stuff for ya tomorrow (today). Good work. 🙂

[dodexahedron]

😭 I lost a review I was working on. I was on my laptop, booted into Ubuntu, writing in Kate, just in case github or my browser acted up.¹

Then the machine hard locked up for a hardware reason I now need to look up the light flash codes for in the repair manual and probably get Dell on-site to replace if necessary. 😤

At least there wasn't anything profound in it, so I can recreate it on another machine. I'll probably do that til I fall asleep, so half an hour or so tonight.

Footnotes

1. Well, not lost per se because it'll be there when I get it working again, but it's not accessible to me right now without taking it apart, which I'm not about to do at half til midnight. 😑 ↩

[dodexahedron]

Ok maybe not so much tonight. After going through some of my github inbox it's already just about midnight, so I'll pick it up tomorrow. Was planning on Tuesday having dedicated time for TG anyway. 🙂

[dodexahedron]

Just a few, this time. After sleeping on it, I scaled it further back from what I had before my laptop exploded, because of scope creep.

After these tweaks, I'd say it's fine to merge.

Then we can get to other changes & enhancements.

[dodexahedron]

I'll start filing new issues targeting this after it is merged.

[dodexahedron]

🥳

Once I finish migrating the Roslyn stuff, I'll get to that draft issue I started a couple days ago.