Remove deprecated deferred.pipe() #1347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 10, 2020 13:44
marcandre
requested changes
Dec 10, 2020
partiellkorrekt
force-pushed
the
master
branch
from
663447a
to
df959eb
Compare
partiellkorrekt
force-pushed
the
master
branch
from
be582f9
to
655db5e
Compare
Remove the debugging-statement and revert dist/doc Remove deferred.pipe Remove the debugging-statement and revert dist/doc undo formatting
partiellkorrekt
force-pushed
the
master
branch
from
f4b4b15
to
ad76cf6
Compare
|
This is ready to merge 👍, but looks like the build is broken (again 😭). I'm sorry I'm not sure when I'll have time to look at that. |
|
@marcandre Hey, can you please check this PR once again? I am also waiting for this change ;) |
wxa
added a commit
to mailpoet/mailpoet
that referenced
this pull request
Feb 18, 2021
Note: deferred.pipe() fix is not implemented yet, see guillaumepotier/Parsley.js#1347
wxa
added a commit
to mailpoet/mailpoet
that referenced
this pull request
Feb 18, 2021
Note: deferred.pipe() fix is not implemented yet, see guillaumepotier/Parsley.js#1347
wxa
added a commit
to mailpoet/mailpoet
that referenced
this pull request
Feb 22, 2021
Note: deferred.pipe() fix is not implemented yet, see guillaumepotier/Parsley.js#1347
wxa
added a commit
to mailpoet/mailpoet
that referenced
this pull request
Feb 22, 2021
Note: deferred.pipe() fix is not implemented yet, see guillaumepotier/Parsley.js#1347
wxa
added a commit
to mailpoet/mailpoet
that referenced
this pull request
Feb 22, 2021
Note: deferred.pipe() fix is not implemented yet, see guillaumepotier/Parsley.js#1347
wxa
added a commit
to mailpoet/mailpoet
that referenced
this pull request
Mar 3, 2021
Note: deferred.pipe() fix is not implemented yet, see guillaumepotier/Parsley.js#1347
veljkho
pushed a commit
to mailpoet/mailpoet
that referenced
this pull request
Mar 3, 2021
Note: deferred.pipe() fix is not implemented yet, see guillaumepotier/Parsley.js#1347
JanJakes
added a commit
to mailpoet/mailpoet
that referenced
this pull request
Jul 20, 2022
This patch replaces deprecated jQuery methods in parsleyjs. It can be removed this when a fix is included in the package update. Note: deferred.pipe() fix is not implemented yet, see guillaumepotier/Parsley.js#1347 [MAILPOET-4485]
JanJakes
added a commit
to mailpoet/mailpoet
that referenced
this pull request
Jul 20, 2022
This patch replaces deprecated jQuery methods in parsleyjs. It can be removed this when a fix is included in the package update. Note: deferred.pipe() fix is not implemented yet, see guillaumepotier/Parsley.js#1347 [MAILPOET-4485]
JanJakes
added a commit
to mailpoet/mailpoet
that referenced
this pull request
Jul 20, 2022
This patch replaces deprecated jQuery methods in parsleyjs. It can be removed this when a fix is included in the package update. Note: deferred.pipe() fix is not implemented yet, see guillaumepotier/Parsley.js#1347 [MAILPOET-4485]
JanJakes
added a commit
to mailpoet/mailpoet
that referenced
this pull request
Jul 26, 2022
This patch replaces deprecated jQuery methods in parsleyjs. It can be removed this when a fix is included in the package update. Note: deferred.pipe() fix is not implemented yet, see guillaumepotier/Parsley.js#1347 [MAILPOET-4485]
JanJakes
added a commit
to mailpoet/mailpoet
that referenced
this pull request
Jul 26, 2022
This patch replaces deprecated jQuery methods in parsleyjs. It can be removed this when a fix is included in the package update. Note: deferred.pipe() fix is not implemented yet, see guillaumepotier/Parsley.js#1347 [MAILPOET-4485]
veljkho
pushed a commit
to mailpoet/mailpoet
that referenced
this pull request
Jul 26, 2022
This patch replaces deprecated jQuery methods in parsleyjs. It can be removed this when a fix is included in the package update. Note: deferred.pipe() fix is not implemented yet, see guillaumepotier/Parsley.js#1347 [MAILPOET-4485]
Merge latest commits from guillaumepotier/Parsley.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As demonstrated by #1226, Parsley.js still uses the deprecated function
deferred.pipeThere has been a fix before: #1253 That fix has been retracted because it doesn't pass the test suite. This fix removes
deferred.pipeand still passes all the tests.