Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 馃悰 prevent reflection headers to be stored on the server #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

petragabriela
Copy link
Contributor

Similar to #42 but fixes the server reflection step. One user's metadata that is used as reflection headers could affect the next user's reflection headers.

STR:

  1. Open grpcox on a browser tab and include some metadata when connecting to a grpc server
  2. Open grpcox on a new browser tab and connect to a grpc server without any metadata
  3. The MD previously used in Step 1 will be sent on the second request (Step 2) too

Fixes the bug by sending the reflection headers directly during server reflection instead of storing them on the Resource

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant