fix: ignore dynamic import for hasModulesyntax
#164
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I initially included dynamic imports to be detected as
hasModuleSyntax = true
in #160.But now I recalled that non-ESM files (e.g. CJS files,
<script>
tag) can contain dynamic imports.This PR will make dynamic import to be ignored for
hasModulesyntax
. Including a dynamic import won't makehasModulesyntax
to betrue
anymore.Users that wants the previous behavior can achieve with
imports.some(i => i.d >= 0) || hasModuleSyntax
.