Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ci on actions. #94

Merged
merged 2 commits into from Oct 8, 2021

Conversation

richardo2016
Copy link
Contributor

@richardo2016 richardo2016 commented Oct 8, 2021

This PR add support to CI based on github actions. Once new commits pushed to specified branchs(e.g, main), or any PR created to original repository's main branch, actions would be triggered to do those check on ALL OS (windows/macOS/Linux):

  • if compilation to WASM valid
  • if lexer (wasm version) valid
  • if compilation to ASM.js valid
  • if lexer (asm.js version) valid
  • benchmark

You can see process of actions here, I have tested it several times @guybedford

image

Copy link
Owner

@guybedford guybedford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, definitely much needed and the setup is great.

Since we don't yet have automated builds for asm.js it may be better to separate that one out for now / comment it out and just focus on supporting the Wasm tests and benchmarks at least.

.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
.github/workflows/build.yml Outdated Show resolved Hide resolved
@guybedford guybedford merged commit c5cdb28 into guybedford:main Oct 8, 2021
@guybedford
Copy link
Owner

Let's try it out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants