Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll the whole page on Left/Right arrows #764

Merged
merged 1 commit into from
May 24, 2024

Conversation

azat
Copy link
Contributor

@azat azat commented Oct 20, 2023

Seeking char by char can take awhile... Or maybe it is done on purpose?

Seeking char by char can take awhile...
@michalfita
Copy link

@azat this looks like semantic change to the existing behaviour; it's a candidate for different shortcut.

TBH: I'm surprised Ctrl+Arrow does just scrolling by the same amount than normal Arrow, I'd expect Ctrl and Shift to modify amount of the movement.

@azat
Copy link
Contributor Author

azat commented Oct 26, 2023

this looks like semantic change to the existing behaviour; it's a candidate for different shortcut.

Scrolling just one column sounds odd anyway, for instance less does not do this (but it seeks half of screen by default, not the whole screen, while it does scroll the whole screen for vertical scroll).

TBH: I'm surprised Ctrl+Arrow does just scrolling by the same amount than normal Arrow, I'd expect Ctrl and Shift to modify amount of the movement.

So as I, I was thinking about using Ctrl+Left/Right instead, but decided that the default looks odd anyway and it could be adjusted, but I'm OK with using different binding for this as well.

@azat
Copy link
Contributor Author

azat commented Mar 30, 2024

Kind ping on this one

azat added a commit to azat/chdig that referenced this pull request Mar 31, 2024
@azat azat mentioned this pull request Mar 31, 2024
@gyscos
Copy link
Owner

gyscos commented May 24, 2024

Hi, and thanks for the work!

Scrolling by 1 column was not a really deep decision, just what I left as default implementation (and, like anything temporary, it sticks forever). Fine to make it scroll a full screen.

@gyscos gyscos merged commit a281c9f into gyscos:main May 24, 2024
2 checks passed
@azat azat deleted the horizontal-page-scroll branch May 24, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants