Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add position and allow 0 margin for text watermark #343

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fajrifernanda
Copy link

@fajrifernanda fajrifernanda commented Jul 13, 2020

Add position(left and top) to set the position of text watermark

and allow 0 margin on text watermark

this is sample of 0 margin, left(0), top(imageheight-fontheight)
resize (1)

* fix text position

* refactor code line
@Eptarch
Copy link

Eptarch commented Sep 14, 2020

Hey, that's great! Just dropping in to say two things:

  1. It will probably be good to add tests to resizer_test.go and vips_test.go
  2. I am really looking forward for @h2non to accept this, because we're going to rely on Imaginary and this exact functionality in our project; and this PR allows these issues to be closed:

@fajrifernanda
Copy link
Author

@Eptarch ok, i will add tests for it, figured out this solution because my project need this functionality too. i just realize there are related issues with this pr

@Leterax
Copy link

Leterax commented Oct 7, 2021

Any plans on merging this?

@huntrist
Copy link

huntrist commented Mar 7, 2022

please merge~

@Drabuna
Copy link

Drabuna commented Jun 15, 2022

bump

@suntong
Copy link

suntong commented Dec 1, 2023

@Eptarch ok, i will add tests for it, figured out this solution because my project need this functionality too. i just realize there are related issues with this pr

Hi @fajrifernanda, did you add some tests to your project later?

@suntong
Copy link

suntong commented Dec 1, 2023

Oh~~~

This branch has conflicts that must be resolved now, after more than three years.

@suntong
Copy link

suntong commented Dec 2, 2023

Hi again @fajrifernanda, would you submit your PR to https://github.com/suntong/bimg/tree/dev as well please?

@suntong
Copy link

suntong commented Dec 2, 2023

Hi again @fajrifernanda, would you submit your PR to https://github.com/suntong/bimg/tree/dev as well please?

NVM, I got it -- suntong@44218a7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants