Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Circle Pack #414

Merged
merged 12 commits into from
May 17, 2024
Merged

Circle Pack #414

merged 12 commits into from
May 17, 2024

Conversation

Brelee2222
Copy link
Contributor

No description provided.

@vercel Vercel
Copy link

vercel bot commented Apr 15, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blot-3dgallery ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 4:37pm

@leomcelroy
Copy link
Contributor

This is more of a tech demo but it's an interesting one to have. That being said can you improve your PR to describe what you've done.

@Brelee2222
Copy link
Contributor Author

This is more of a tech demo but it's an interesting one to have. That being said can you improve your PR to describe what you've done.

Should I put the description in a README file?

@leomcelroy
Copy link
Contributor

You could do that but just writing a description here is also okay.

@leomcelroy
Copy link
Contributor

Also snapshot should reference one of the file names in your snapshots folder.

@Brelee2222
Copy link
Contributor Author

Also snapshot should reference one of the file names in your snapshots folder.

wydm?

@Brelee2222
Copy link
Contributor Author

Brelee2222 commented Apr 25, 2024 •
edited

Also snapshot should reference one of the file names in your snapshots folder.

wydm?

oh okay

@Brelee2222
Copy link
Contributor Author

Also snapshot should reference one of the file names in your snapshots folder.

wydm?

oh okay

It does 👍

@leomcelroy
Copy link
Contributor

This

@snapshot: circlePacker

should be this

@snapshot: circlePacker.png

@Brelee2222
Copy link
Contributor Author

circlePacker

👍

@leomcelroy
Copy link
Contributor

Okay I fixed it for you. You can order your Blot here. Congrats!

@leomcelroy leomcelroy merged commit 662b2e8 into hackclub:main May 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved submission
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Brelee2222 @leomcelroy