Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fiscal Sponsorship: Add contact info & climate commitment #1114

Merged
merged 7 commits into from Mar 19, 2024
Merged

Conversation

lachlanjc
Copy link
Member

On landing page:
CleanShot 2024-03-14 at 23 44 01@2x

CleanShot 2024-03-14 at 23 44 10@2x

I've added a clear banner there to encourage contacting us, and reversed the footer changes since I think they're more confusing.

On Apply page, repeating the contact info:
CleanShot 2024-03-14 at 23 43 42@2x

@lachlanjc lachlanjc requested a review from garyhtou March 15, 2024 03:46
Copy link

vercel bot commented Mar 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 19, 2024 6:21pm

Copy link
Member

@garyhtou garyhtou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Just one minor styling issue on large monitors

thanks for working on this!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we plan to keep the footer consistent across all pages (and not have an HCB-specific footer), then maybe should we remove the props in the Footer component.

const Footer = ({
dark = false,
email = 'team@hackclub.com',
phoneNumber = '1-855-625-HACK',
phoneNumberUri = '1-855-625-HACK',

Comment on lines +31 to +32
Questions? Email <Link href={`mailto:${email}`}>{email}</Link>{' '}
or&nbsp;call <Link href={`tel:${phoneNumberUri}`}>{phoneNumber}</Link>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this! thanks!

pages/fiscal-sponsorship/apply/index.js Outdated Show resolved Hide resolved
@zachlatta
Copy link
Member

I think this is good, but please add contact info above the fold and put Mel or Paul's info

lachlanjc and others added 2 commits March 19, 2024 14:17
Co-authored-by: Gary Tou <gary@garytou.com>
@lachlanjc lachlanjc added this pull request to the merge queue Mar 19, 2024
Merged via the queue into main with commit 6ba5dd6 Mar 19, 2024
4 checks passed
@lachlanjc lachlanjc deleted the fs-banners branch March 19, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants