Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Lax for the SameSite attribute on cookies #1670

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Set Lax for the SameSite attribute on cookies #1670

wants to merge 3 commits into from

Conversation

mic4ael
Copy link
Contributor

@mic4ael mic4ael commented Apr 1, 2021

No description provided.

@mic4ael
Copy link
Contributor Author

mic4ael commented Jul 19, 2021

Can anyone have a look at this?

@mic4ael
Copy link
Contributor Author

mic4ael commented Jul 19, 2021 •
edited

Actually, this requires a new release of js-cookie so changing it to a Draft PR.

@mic4ael mic4ael marked this pull request as draft July 19, 2021 10:19
@mic4ael
Set Lax for the SameSite attribute
e608f57 
Signed-off-by: Michal Kolodziejski <michal.kolodziejski@cern.ch>
@mic4ael
Set secure attribute on cookies if possible
c8eab94 
Signed-off-by: Michal Kolodziejski <michal.kolodziejski@cern.ch>
@mic4ael mic4ael marked this pull request as ready for review August 3, 2021 10:13
@mic4ael
Upgrade js-cookie to v3.0.0
01392c9 
Signed-off-by: Michal Kolodziejski <michal.kolodziejski@cern.ch>
@jackycute
Copy link
Member

Hi @mic4ael,

Thanks for opening this PR.
I think this will take some time to review if case we missed any cookie not been set to Lax.
Also, I'm wondering is there any way we can migrate existing cookie to Lax or the only way is ask user to sign out and sign in again.

@mic4ael
Copy link
Contributor Author

mic4ael commented Oct 11, 2021

Hi @mic4ael,

Thanks for opening this PR. I think this will take some time to review if case we missed any cookie not been set to Lax. Also, I'm wondering is there any way we can migrate existing cookie to Lax or the only way is ask user to sign out and sign in again.

Shouldn't this be done by the browser? If the server sends an updated cookie, I would assume that the browser updates it appropriately.

edgarogh pushed a commit to WartaPoirier-corp/codimd that referenced this pull request Jun 7, 2022
@InnayTool
Merge pull request hackmdio#1670 from hedgedoc/renovate/master-mermai…
b9d933a 
…d-8.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mic4ael @jackycute