fix line ending #197
Merged
fix line ending #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #197 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 28 28
Lines 2879 2880 +1
=========================================
+ Hits 2879 2880 +1
|
wby default on file writes the line ending is replaced by os.linesep, so our own line endings do not persist. This can be fixed by passing the appropriate line ending.
|
Code Climate has analyzed commit 93d96ae and detected 0 issues on this pull request. View more on Code Climate. |
|
@maxbachmann I've finalized the PR, if you don't mind, could you please verify that this fix works? Thanks a lot for supporting the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by default on file writes the line ending is replaced by os.linesep, so our own line endings do not persist. This can be fixed by passing the appropriate line ending.
Fixes: #202