fixes issue #2018 - control video from speaker view in main window #3223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issue #2018
It allows the speaker view to control/sync the video in the main window (only one way).
The following operations are supported:
There is currently the issue that all instances of reveal.js (across all tabs) are synced as a
BroadcastChannelis used.This could be solved by adding a unique session id to the reveal instance.
How it works:
After the plugin is loaded all video elements are found and listeners are attached to the events (play, pause, ...).
In the listener the xpath for the video element is queried and a command is send to the other instance (main view) which received the command and the xpath. Via the xpath the same element is found and the command is executed.