Add support for extended exp operation as halide_extended_exp. #8206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * "The Two-Pass Softmax Algorithm" by Marat Dukhan and | ||
| * Artsiom Ablavatski [https://arxiv.org/abs/2001.04438]. | ||
| * | ||
| * The first element of the returned Tuple is a psuedo-mantissa while |
| * Artsiom Ablavatski [https://arxiv.org/abs/2001.04438]. | ||
| * | ||
| * The first element of the returned Tuple is a psuedo-mantissa while | ||
| * the second is an exponent which is an integer. The product of the |
There was a problem hiding this comment.
So is the returned Tuple a pair of (float32, int32), or is it (float32, float32) where the second is always an integral value?
Can you clarify a bit? It's not obvious to me what the deficiencies are (just curious) |
added 2 commits
April 30, 2024 22:43
values for exponent part of extended exp. Improve test by comparing to three pass algorithm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion, add operator to implement efficient two pass softmax algorithm. This is a draft as it is hoped the numerics can be improved.