Rework the simplifier to use ConstantInterval for bounds #8222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The associative ops table defined saturating add as saturating_narrow(widen(x + y)), instead of saturating_narrow(widen(x) + y)
A default-constructed ModulusRemainder means no information, which is
what we want here. ModulusRemainder{0, 1} means the constant one!
and track the bounds through more types
…erflow' into abadams/constant_interval_simplifier
…iativity' into abadams/constant_interval_simplifier
Otherwise it causes a race condition in any parallel tests
The contradiction was arising from:
if (extent > 0) {
...
} else {
for (x = 0; x < extent; x++) {
In here we can assume extent > 0, but we also know from the if
statement that extent <= 0
}
}
rootjalex
reviewed
May 25, 2024
rootjalex
reviewed
May 25, 2024
rootjalex
reviewed
May 25, 2024
rootjalex
reviewed
May 27, 2024
rootjalex
reviewed
May 27, 2024
rootjalex
reviewed
May 27, 2024
rootjalex
reviewed
May 27, 2024
rootjalex
reviewed
May 27, 2024
rootjalex
reviewed
May 27, 2024
|
Failures unrelated. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that ConstantInterval is more powerful, this PR reworks the simplifier to use it for bounds information. This is not quite just a refactor PR, because it also tracks bounds for many more types, resulting in better simplification of e.g. fixed-point expressions.
I also moved the simplify fuzzer back to being a correctness test (see #8171)
Also includes bug-fixes #8220 and #8221, because those would otherwise break this PR. There are no files in common, so if you want to review before those are merged, just ignore the associativity and modulus remainder changes.