-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
为aside添加可折叠效果 #4407
为aside添加可折叠效果 #4407
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4407 +/- ##
=========================================
Coverage 61.07% 61.07%
Complexity 2566 2566
=========================================
Files 374 374
Lines 13162 13162
Branches 937 937
=========================================
Hits 8039 8039
Misses 4670 4670
Partials 453 453 ☔ View full report in Codecov by Sentry. |
下面是一些建议:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 建议将“折叠和展开”按钮放置在左下角。
- 展开时动画不够平滑。
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @GodlessLiu ,请问有最新进展么? |
因长时间未回应,我将关闭当前 PR。 /close |
@JohnNiang: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind improvement
/area console
What this PR does / why we need it:
面板侧栏可能会占用部分空间,为侧栏添加折叠按钮,添加主要内容的展示面积。
Which issue(s) this PR fixes:
Fixes #4197
Special notes for your reviewer:
测试方式:
Does this PR introduce a user-facing change?