Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: email notifications are now sent only to verified email addresses #5905

Merged
merged 1 commit into from
May 20, 2024

Conversation

guqing
Copy link
Member

@guqing guqing commented May 13, 2024

What type of PR is this?

/kind improvement
/area core
/milestone 2.16.x

What this PR does / why we need it:

邮件通知功能现在只向经过验证的邮箱地址发送通知匿名用户除外

Which issue(s) this PR fixes:

Fixes #5722

Does this PR introduce a user-facing change?

邮件通知功能现在只向经过验证的邮箱地址发送通知匿名用户除外

@f2c-ci-robot f2c-ci-robot bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/improvement Categorizes issue or PR as related to a improvement. labels May 13, 2024
@f2c-ci-robot f2c-ci-robot bot added this to the 2.16.x milestone May 13, 2024
@f2c-ci-robot f2c-ci-robot bot added the area/core Issues or PRs related to the Halo Core label May 13, 2024
@f2c-ci-robot f2c-ci-robot bot requested review from LIlGG and wan92hen May 13, 2024 09:18
Copy link

sonarcloud bot commented May 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.2% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@f2c-ci-robot f2c-ci-robot bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 20, 2024
Copy link
Member

@ruibaby ruibaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@f2c-ci-robot f2c-ci-robot bot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2024
Copy link

f2c-ci-robot bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JohnNiang, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@f2c-ci-robot f2c-ci-robot bot merged commit d2a9c80 into halo-dev:main May 20, 2024
8 checks passed
@guqing guqing deleted the refactor/5722 branch May 20, 2024 09:39
@ruibaby ruibaby modified the milestones: 2.16.x, 2.16.0 May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/core Issues or PRs related to the Halo Core kind/improvement Categorizes issue or PR as related to a improvement. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

期望用户邮箱通知时只通知已验证的邮箱
3 participants