refactor: optimize auth provider sorting with drag-and-drop support #5914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f2c-ci-robot
bot
added
do-not-merge/work-in-progress
f2c-ci-robot
bot
added
kind/feature
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5914 +/- ##
============================================
- Coverage 56.91% 56.61% -0.30%
- Complexity 3319 3468 +149
============================================
Files 587 612 +25
Lines 18968 20532 +1564
Branches 1401 1419 +18
============================================
+ Hits 10795 11624 +829
- Misses 7594 8324 +730
- Partials 579 584 +5 ☔ View full report in Codecov by Sentry. |
|
@ruibaby 帮忙为认证方式列表加上拖拽排序的功能 |
f2c-ci-robot
bot
added
the
needs-rebase
Signed-off-by: Ryan Wang <i@ryanc.cc>
f2c-ci-robot
bot
removed
the
needs-rebase
|
f2c-ci-robot
bot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JohnNiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f2c-ci-robot
bot
added
the
approved
This was referenced May 21, 2024
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
May 21, 2024
#### What type of PR is this? /area ui /kind improvement /milestone 2.16.x #### What this PR does / why we need it: 优化菜单管理相关的 UI 代码。 1. 使用 vue-draggable-plus 库代替 vuedraggable 库实现拖拽排序。vue-draggable-plus 是在 #5914 中引入，替换的原因是 vuedraggable 库已经不再积极维护。 2. 改进菜单和菜单项编辑表单的逻辑，清理无用代码。 #### Special notes for your reviewer: 需要测试： 1. 测试菜单项拖拽排序功能是否表现正常。 2. 测试新增菜单、菜单项和修改菜单、菜单项功能是否表现正常。 #### Does this PR introduce a user-facing change? ```release-note None ```
f2c-ci-robot bot
pushed a commit
that referenced
this pull request
May 22, 2024
#### What type of PR is this? /area ui /kind improvement /milestone 2.16.x #### What this PR does / why we need it: 优化文章分类管理相关的 UI 代码。 1. 使用 vue-draggable-plus 库代替 vuedraggable 库实现拖拽排序。vue-draggable-plus 是在 #5914 中引入，替换的原因是 vuedraggable 库已经不再积极维护。 2. 改进分类编辑表单的逻辑，清理无用代码。 #### Special notes for your reviewer: 需要测试： 1. 测试文章分类拖拽排序功能是否表现正常。 2. 测试新增/编辑文章分类功能是否表现正常。 #### Does this PR introduce a user-facing change? ```release-note None ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/area core
/area ui
/milestone 2.16.x
What this PR does / why we need it:
优化认证方式的排序并支持拖动
Which issue(s) this PR fixes:
Fixes #5813
Does this PR introduce a user-facing change?