Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsUnmodifiableCollection matcher feature #249 #379

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nhojpatrick
Copy link
Member

(cherry picked from commit 0ba3f59)

@Andremoniy could you take a look at this and this error https://github.com/hamcrest/JavaHamcrest/runs/5176851243?check_suite_focus=true as it's breaking once we bump source to java 1.8 and run on java 17, 18-ea or 19-ea.

@Andremoniy
Copy link
Contributor

Andremoniy commented Feb 13, 2022

(cherry picked from commit 0ba3f59)

@Andremoniy could you take a look at this and this error https://github.com/hamcrest/JavaHamcrest/runs/5176851243?check_suite_focus=true as it's breaking once we bump source to java 1.8 and run on java 17, 18-ea or 19-ea.

Yes, I already noticed it and I am checking what can be done

@Andremoniy
Copy link
Contributor

(cherry picked from commit 0ba3f59)

@Andremoniy could you take a look at this and this error https://github.com/hamcrest/JavaHamcrest/runs/5176851243?check_suite_focus=true as it's breaking once we bump source to java 1.8 and run on java 17, 18-ea or 19-ea.

Dear @nhojpatrick, I have addressed the issues in a new PR: #381
Could you check it please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants