Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with recent PHPUnit (8) #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Compatibility with recent PHPUnit (8) #68

wants to merge 1 commit into from

Conversation

DavidPrevot
Copy link

No description provided.

@davedevelopment
Copy link
Member

Thank you David, looks like we'll need to drop 7.0 support to merge this?

@DavidPrevot
Copy link
Author

I believe it will only work with PHPUnit >=7.

gnovaro
gnovaro approved these changes Mar 22, 2021
View reviewed changes
Copy link

@gnovaro gnovaro left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. void is a return type indicating the function does not return a value. Therefore it cannot be part of a union type declaration. Available as of PHP 7.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnovaro gnovaro gnovaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DavidPrevot @davedevelopment @gnovaro