Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented path recognizer for recognizing along an SVGpath #991

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OpherV
Copy link

@OpherV OpherV commented Jun 15, 2016

feat: path recognizer for recognizing along an SVGpath

Implement a recognizer that receives an SVG element and an SVG Path element, and recognizes a user following the path. Recognizer will fail if user starts gesturing at the middle of the path, veers too far from the path or stops input mid-way.

Special parameters:
resolution (default 10) - path will be quantized to this amount of segments
maxDistanceFromSegment (default 30) - the threshold in which input is allowed to stray from the path
Example use case: games where the player needs to follow an onscreen shape to achieve a goal.

Includes a pathRecognizer test in the manual tests dir.

path

@runspired
Copy link
Contributor

@arschmitz this is really interesting, at first I thought perhaps this was outside the scope of the core lib, but the more I think about it the more I'd love to see something like this within the lib itself.

@arschmitz
Copy link
Contributor

@runspired i actually totally agree iv been going back and forth with my self over this one but im leaning towards inclusion

@OpherV
Copy link
Author

OpherV commented Jul 28, 2016

@runspired @arschmitz Actually if I had the option I would have written it as a separate module and not as a PR to the hammer core. However after looking at the architecture currently there's no good way to add new recognizers dynamically to hammer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants