Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ajsf/bs5) Add bootstrap 5 support #320

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
41 changes: 21 additions & 20 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@ on:
workflow_dispatch:
inputs:
logLevel:
description: 'Log level'
description: "Log level"
required: true
default: 'warning'
default: "warning"
push:
branches: [ main ]
branches: [main]
pull_request:
branches: [ main ]
branches: [main]

jobs:
ci:
Expand All @@ -21,19 +21,20 @@ jobs:
node-version: [16.x, lts/*]

steps:
- uses: actions/checkout@v3
- name: Setup Node ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- run: npm ci
- name: Build libs and demo
run: npm run build:demo
- name: Test libs
run: |
npm run test:core -- --browsers=ChromeHeadlessNoSandbox --codeCoverage=true --watch=false
npm run test:bs3 -- --browsers=ChromeHeadlessNoSandbox --codeCoverage=true --watch=false
npm run test:bs4 -- --browsers=ChromeHeadlessNoSandbox --codeCoverage=true --watch=false
npm run test:material -- --browsers=ChromeHeadlessNoSandbox --codeCoverage=true --watch=false
- name: Publish code coverage
run: npm run publish:coverage
- uses: actions/checkout@v3
- name: Setup Node ${{ matrix.node-version }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- run: npm ci
- name: Build libs and demo
run: npm run build:demo
- name: Test libs
run: |
npm run test:core -- --browsers=ChromeHeadlessNoSandbox --codeCoverage=true --watch=false
npm run test:bs3 -- --browsers=ChromeHeadlessNoSandbox --codeCoverage=true --watch=false
npm run test:bs4 -- --browsers=ChromeHeadlessNoSandbox --codeCoverage=true --watch=false
npm run test:bs5 -- --browsers=ChromeHeadlessNoSandbox --codeCoverage=true --watch=false
npm run test:material -- --browsers=ChromeHeadlessNoSandbox --codeCoverage=true --watch=false
- name: Publish code coverage
run: npm run publish:coverage
8 changes: 8 additions & 0 deletions .github/workflows/dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -44,3 +44,11 @@ updates:
open-pull-requests-limit: 5
commit-message:
prefix: "build"
- package-ecosystem: "npm"
directory: "/projects/ajsf-bootstrap5"
schedule:
interval: "weekly"
day: "sunday"
open-pull-requests-limit: 5
commit-message:
prefix: "build"
52 changes: 27 additions & 25 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,20 +33,20 @@ of new features.

To send your code change, use GitHub pull requests. The workflow is as follows:

1. Fork the project.
1. Fork the project.

1. Create a branch based on `main`.
1. Create a branch based on `main`.

1. Implement your change, including tests and documentation.
1. Implement your change, including tests and documentation.

1. Run tests to make sure your change didn't break anything.
1. Run tests to make sure your change didn't break anything.

1. Publish the branch and create a pull request.
1. Publish the branch and create a pull request.

1. ajsf developers will review your change and possibly point out issues.
Adapt the code under their guidance until all issues are resolved.
1. ajsf developers will review your change and possibly point out issues.
Adapt the code under their guidance until all issues are resolved.

1. Finally, the pull request will get merged or rejected.
1. Finally, the pull request will get merged or rejected.

See also [GitHub's guide on contributing](https://help.github.com/articles/fork-a-repo).

Expand Down Expand Up @@ -80,7 +80,8 @@ functional changes into one commit. When writing commit messages, adhere to
[Angular Conventional Commit](https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-commit-message-guidelines).

#### Commit Message Format
Each commit message consists of a **header**, a **body** and a **footer**. The header has a special

Each commit message consists of a **header**, a **body** and a **footer**. The header has a special
format that includes a **type**, a **scope** and a **subject**:

```
Expand Down Expand Up @@ -112,29 +113,30 @@ The version in our package.json gets copied to the one we publish, and users nee

Must be one of the following:

* **build**: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
* **ci**: Changes to our CI configuration files and scripts (example scopes: Circle, BrowserStack, SauceLabs)
* **docs**: Documentation only changes
* **feat**: A new feature
* **fix**: A bug fix
* **perf**: A code change that improves performance
* **refactor**: A code change that neither fixes a bug nor adds a feature
* **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
* **test**: Adding missing tests or correcting existing tests
- **build**: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
- **ci**: Changes to our CI configuration files and scripts (example scopes: Circle, BrowserStack, SauceLabs)
- **docs**: Documentation only changes
- **feat**: A new feature
- **fix**: A bug fix
- **perf**: A code change that improves performance
- **refactor**: A code change that neither fixes a bug nor adds a feature
- **style**: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
- **test**: Adding missing tests or correcting existing tests

#### Scope

The scope should be the name of the npm package affected (as perceived by the person reading the changelog generated from commit messages).

The following is the list of supported scopes:

* **ajsf/core**
* **ajsf/bs3**
* **ajsf/bs4**
* **ajsf/material**
* **locales**
* **demo**
* ...
- **ajsf/core**
- **ajsf/bs3**
- **ajsf/bs4**
- **ajsf/bs5**
- **ajsf/material**
- **locales**
- **demo**
- ...

When the commit fixes a bug, put a message in the body of the commit message
pointing to the number of the issue (e.g. "Fixes #123").
Expand Down