Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for function SUM and operator ^ #1409

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Apr 25, 2024

Context

Unit tests written when analyzing the behavior of function SUM and operator ^.

How did you test your changes?

unit tests pass

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • New unit tests

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.

Copy link

github-actions bot commented Apr 25, 2024

Performance comparison of head (dcc9be8) vs base (b18f616)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 553.17 | 545.09 | -1.46%
                                      Sheet B |  186.6 | 180.82 | -3.10%
                                      Sheet T |    162 | 160.61 | -0.86%
                                Column ranges | 567.76 | 560.84 | -1.22%
Sheet A:  change value, add/remove row/column |   15.9 |  15.32 | -3.65%
 Sheet B: change value, add/remove row/column | 133.24 |  137.5 | +3.20%
                   Column ranges - add column | 166.19 | 157.82 | -5.04%
                Column ranges - without batch | 489.06 | 458.12 | -6.33%
                        Column ranges - batch | 127.15 | 118.09 | -7.13%

@sequba sequba self-assigned this Apr 25, 2024
@sequba sequba requested a review from evanSe April 25, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant