Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change virtual module id to prefix with virtual: #468

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

callqh
Copy link
Contributor

@callqh callqh commented Mar 19, 2024

Description

Modify the name of the virtual module to conform to the specification of vite and rollup so that it can be easily used in other frameworks.

Additional context

If the name is not standardized, some frameworks will resolve it as an absolute path because the name does not have the virtual: identifier and starts with /.


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

Modify the name of the virtual module to conform to the specification of vite and rollup so that it can be easily used in other frameworks.
@callqh
Copy link
Contributor Author

callqh commented Mar 19, 2024

hannoeru
hannoeru previously approved these changes Mar 21, 2024
src/constants.ts Outdated Show resolved Hide resolved
@hannoeru hannoeru changed the title fix: modify the name of the virtual module fix: change virtual module id to prefix with virtual: Mar 21, 2024
@hannoeru hannoeru enabled auto-merge (squash) March 21, 2024 01:52
@hannoeru hannoeru disabled auto-merge March 21, 2024 01:53
@hannoeru hannoeru merged commit 8298c3a into hannoeru:main Mar 21, 2024
8 checks passed
@hannoeru
Copy link
Owner

Thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants