Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Joi issue #2736: #2845

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix Joi issue #2736: #2845

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/modify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ internals.fork = function (schema, id, replacement) {

const each = (item, { key }) => {

if (id === (item._flags.id || key)) {
if (id === item._flags.id || id === key) {
return replacement;
}
};
Expand Down
11 changes: 11 additions & 0 deletions test/extend.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1298,6 +1298,17 @@ describe('extension', () => {
expect(schema.$_getFlag('_hasNumbers')).to.be.true();
});

it('fork in schema using id fails once rules applied on base schema are not being followed', () => {

const innerSchema = Joi.object({}).id('myId');
const baseSchema = Joi.object({
myField: innerSchema
});
const strictSchema = baseSchema.fork('myField', (keySchema) => keySchema.required());
const { error } = strictSchema.validate({});
expect(error).to.be.an.error('"myField" is required');
});

it('supports fork', () => {

const custom = Joi.extend((joi) => {
Expand Down