Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tighten type checking config #1071

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

Conversation

kanongil
Copy link
Contributor

This adds noUncheckedIndexedAccess: true and exactOptionalPropertyTypes: true to the type checking config.

This helps ensure that the defined typings can work for projects like reported here, which use these stricter than strict: true options.

I also updated the peer dependency requirement to v4.4.0+, which is the oldest version that supports these flags.

@kanongil kanongil added feature New functionality or improvement breaking changes Change that can breaking existing code labels Dec 28, 2023
@kanongil
Copy link
Contributor Author

The 316d8c1 patch can be omitted, if #1070 is merged. Otherwise, two additional codes need to be added to the list to handle the expect.error() lines in b801fae.

Copy link
Member

@devinivy devinivy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for getting this going 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking changes Change that can breaking existing code feature New functionality or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants