It was possible for the TargetManager initialization to finish withou…

…t having discovered all targets. This was causing unit tests such as PuppeteerConnectTests.ShouldSupportTargetFilter to fail because the test executed faster than the target discovery.
hardkoded · Jun 2, 2023 · 84c3dd5 · 84c3dd5
1 parent deb351d
commit 84c3dd5
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/lib/PuppeteerSharp/ChromeTargetManager.cs b/lib/PuppeteerSharp/ChromeTargetManager.cs
@@ -93,7 +93,9 @@ await _connection.SendAsync("Target.setAutoAttach", new TargetSetAutoAttachReque
                 AutoAttach = true,
             }).ConfigureAwait(false);
 
+            await _targetDiscoveryCompletionSource.Task.ConfigureAwait(false);
             FinishInitializationIfReady();
+
             await _initializeCompletionSource.Task.ConfigureAwait(false);
         }