Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed threshold 10 epochs #4671

Merged
merged 1 commit into from
May 27, 2024
Merged

Removed threshold 10 epochs #4671

merged 1 commit into from
May 27, 2024

Conversation

Frozen
Copy link
Contributor

@Frozen Frozen commented May 16, 2024

Removes threshold for 10 blocks for devnet crosslinks fix.

@sophoah
Copy link
Contributor

sophoah commented May 17, 2024

Hey @Frozen, instead of removing the crosslink outright, can we first check whether it has already been processed? If it has, then we can proceed with the removal. This particular piece of code was a legitimate removal due to a previous mainnet issue where old pending crosslinks, which had already been processed, were stuck in the database.

@Frozen
Copy link
Contributor Author

Frozen commented May 17, 2024

Hey @Frozen, instead of removing the crosslink outright, can we first check whether it has already been processed? If it has, then we can proceed with the removal. This particular piece of code was a legitimate removal due to a previous mainnet issue where old pending crosslinks, which had already been processed, were stuck in the database.

As i can understand the next line of code does what you expect link

@GheisMohammadi GheisMohammadi self-requested a review May 23, 2024 11:46
@sophoah sophoah merged commit 338ff01 into dev May 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants