Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FFM-4572 - Update Go version, allow custom cache, add initalLoad flag, standardise segment and flags being set #98

Merged
merged 8 commits into from Oct 5, 2022
Merged

FFM-4572 - Update Go version, allow custom cache, add initalLoad flag, standardise segment and flags being set #98

merged 8 commits into from Oct 5, 2022

Conversation

stephenmcconkey
Copy link
Contributor

@stephenmcconkey stephenmcconkey commented Sep 28, 2022 •
edited

What

  1. Update Go to 1.18
  2. Change go get to go install for openapi codegen in makefile
  3. Allow for custom cache to be honoured when set in client config
  4. Add initalLoad flag to prevent outdated check on initial load of flags and segments, because new logic causes a lot of error logging on first load as you are trying to check against something that cannot exist. This is set as true on retrieveFlags, segments, then on event updates set as false.
  5. Update tests so that state is accurately set, was "true"/"false" should be "on"/"off"
  6. flagKey and segmentKey is inconsistently set/get across the board
  7. Pin Golangci-lint version (issue - Go 1.18.4 and golangci 1.48: "Error: File is not gofmt-ed with -s (gofmt)" golangci/golangci-lint-action#535)

Why
Changes are necessary to keep consistency and allow for the proxy/other applications to use the client

Testing
Manually tested Bool, Json, String, Number flags
Manually tested PreReqs and targets
Fixed Unit tests where applicable

@swarmia
Copy link

swarmia bot commented Sep 28, 2022

✅  Linked to Bug FFM-4572 · Proxy integration with latest Golang SDK not writing to Redis

@stephenmcconkey stephenmcconkey changed the title FFM-4572 FFM-4572 - Update Go SDK so Client evaluations are consistent Oct 4, 2022
@stephenmcconkey stephenmcconkey changed the title FFM-4572 - Update Go SDK so Client evaluations are consistent FFM-4572 - Update Go version, allow custom cache, add initalLoad flag, standardise segment and flags being set Oct 4, 2022
@stephenmcconkey stephenmcconkey merged commit bad5711 into main Oct 5, 2022
davejohnston pushed a commit to davejohnston/ff-golang-server-sdk that referenced this pull request Sep 26, 2023
@stephenmcconkey @davejohnston
FFM-4572 - Update Go version, allow custom cache, add initalLoad flag…
9254d03 
…, standardise segment and flags being set (harness#98)

* Update Go version in SDK
* Add logic to allow user defined cache to be populated
* Add flag for initial load so that oldflag check doesn't occur on first load
* Update to use more recent ff-test-cases submodule
* Pin version of Go lint as per golangci/golangci-lint-action#535
@erdirowlands erdirowlands deleted the FFM-4572 branch November 3, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@conormurray95 conormurray95 conormurray95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stephenmcconkey @conormurray95