Fix multiple value ranges serialisation (#316)

harrisiirak · Mar 7, 2023 · b4d22ef · b4d22ef
1 parent a548a51
commit b4d22ef
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 2 deletions.
diff --git a/lib/field_stringify.js b/lib/field_stringify.js
@@ -31,7 +31,20 @@ function stringifyField(arr, min, max) {
 
     var multiplier = range.start == 0 ? range.count - 1 : range.count;
     if (range.step * multiplier > range.end) {
-      result.push(arr.join(','));
+      result = result.concat(
+         Array
+          .from({ length: range.end - range.start + 1 })
+          .map(function (_, index) {
+            var value = range.start + index;
+            if ((value - range.start) % range.step === 0) {
+              return value;
+            }
+            return null;
+          })
+          .filter(function (value) {
+            return value != null;
+          })
+      );
     } else if (range.end === max - range.step + 1) {
       result.push(range.start + '/' + range.step);
     } else {

diff --git a/test/field_stringify.js b/test/field_stringify.js
@@ -35,14 +35,24 @@ test('stringify single value', function (t) {
 
 test('stringify multiple single values', function (t) {
   try {
-    var str = stringifyField([2, 5, 9], 0, 7);
+    var str = stringifyField([2, 5, 9], 0, 9);
     t.equal(str, '2,5,9');
   } catch (err) {
     t.error(err, 'stringify field error');
   }
   t.end();
 });
 
+test('stringify multiple ranged values', function (t) {
+  try {
+    var str = stringifyField([1, 3, 5, 6], 0, 9);
+    t.equal(str, '1,3,5,6');
+  } catch (err) {
+    t.error(err, 'stringify field error');
+  }
+  t.end();
+});
+
 test('stringify range', function (t) {
   try {
     var str = stringifyField([2, 3, 4], 0, 7);